Make can-define-stream mixin based

[justinbmeyer]

Steps

• [x] - Rename can-stream to can-stream-kefir.
• [ ] - Add a canStreamKefir.toCompute( func(setStream):stream ) that returns a compute that when set, fires an event on the setStream ... and the value of the compute is the last value of the returned stream. needed so can-define-stream wouldn't need Kefir.
• [ ] - Create can-define-stream-kefir for easier mixins like:

  var canDefineStream = require("can-define-stream-kefir");
  var Type = DefineMap.extend({ ... });
  canDefineStream( Type);

• [ ] - Change can-define-stream to a helper that takes a CanJS-ified stream library and provides the mixin like:

  var defineStream = require("can-define-stream");
  var canStreamRXJS = require("can-stream-rxjs");
  var Type = DefineMap.extend({ ... });
  defineStream( canStreamRXJS )( Type);

Benefits

• Allow alternate streaming libs
• "keeps code working forever"

[Bajix]

I think we can accomplish this easier by making can-stream & can-define-stream decoupled from RxJS / Kefir, and then loading in either interchangeably, maybe via can-namespace.

"meta": {
  "can-stream": {
    "deps": [
      "can-stream-kefir"
    ]
  }
}

"meta": {
  "can-stream": {
    "deps": [
      "can-stream-rxjs"
    ]
  }
}

This then would have the benefit that anything can-stream-kefir compatible would also be can-stream-rxjs compatible. Authors could write using can-stream-kefir if they don't need the full API & users then could transparently swap in can-stream-rxjson an as needed basis.

[justinbmeyer]

They can't really be used interchangeably because their streams have different APIs.

There needs to be a specific stream integration for each. Can explain at Friday's meeting.

Sent from my iPhone

On Dec 29, 2016, at 6:26 PM, Thomas Sieverding notifications@github.com wrote:

I think we can accomplish this easier by making can-stream & can-define-stream decoupled from RxJS / Kefir, and then loading in either interchangeably, maybe via can-namespace.

"meta": { "can-stream": { "deps": [ "can-stream-kefir" ] } }

"meta": { "can-stream": { "deps": [ "can-stream-rxjs" ] } } This then would have the benefit that anything can-stream-kefir compatible would also be can-stream-rxjs compatible. Authors could write using can-stream-kefir if they don't need the full API & users then could transparently swap in can-stream-rxjson an as needed basis.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[Bajix]

How far off are their API's? RxJS has a lot more functionality for sure, but the overlap looked considerable. Drop in substitution would be really awesome if possible

[web-mech]

https://github.com/web-mech/can-stream-rxjs https://github.com/web-mech/can-define-stream-rxjs