canjs / can-define-validate-validatejs

ValidateJS plugin for can-define
https://canjs.com/doc/can-define-validate-validatejs.html
MIT License
2 stars 0 forks source link

can-define-validate-validatejs demo is not working #16

Closed phillipskevin closed 6 years ago

phillipskevin commented 7 years ago

@pYr0x commented on Tue May 23 2017

the demo is not working. http://canjs.com/doc/can-define-validate-validatejs.html


Error loading "validate.js@0.11.1#validate" from "undefined" at <unknown>
Not Found: http://canjs.com/node_modules/validate.js/validate/index.js" undefined```
Macrofig commented 7 years ago

When was the last time we deployed the site? This issue was fixed here: https://github.com/canjs/canjs/pull/3191

chasenlehara commented 7 years ago

That fix doesn’t look right to me; I think you need to include node_modules/validate.js so the package’s files are deployed as well.

Macrofig commented 7 years ago

@chasenlehara So instead of git add -f node_modules/validate.js/package.json I should have git add -f node_modules/validate.js?

chasenlehara commented 7 years ago

I think so.

Macrofig commented 7 years ago

@justinbmeyer @phillipskevin Can you confirm the fix?

justinbmeyer commented 6 years ago

yes, if that adds everything in the validate.js folder