v3: can-define/list fails to unregister event handlers in some circumstances

canjs / can-define

Observable properties

https://canjs.com/doc/can-define.html

MIT License

15 stars 7 forks source link

v3: can-define/list fails to unregister event handlers in some circumstances #455

Closed RyanMilligan closed 5 years ago

RyanMilligan commented 5 years ago

How often can you reproduce it?

[x] Always
[ ] Sometimes
[ ] Rarely
[ ] Unable
[ ] I didn’t try

Description: In can-define/list/list.js, the offKeyValue function creates a new function and then attempts to remove it from the event handler, which of course will never do anything. It needs to track the one created by onKeyValue a few lines up and remove that, in this case.

justinbmeyer commented 5 years ago

https://github.com/canjs/can-define/blob/e963a7c3adde071b6380908544d3e99a6915e1b7/list/list.js#L1538

bmomberger-bitovi commented 5 years ago

Closed via #456 and #459