canjs / can-list-sort

Live-bound list sorting
MIT License
1 stars 0 forks source link

Make sorting work against 3.0 - P(2) ~21 #1

Closed justinbmeyer closed 7 years ago

justinbmeyer commented 8 years ago

Ideally it could work against DefineList and List.

christopherjbaker commented 7 years ago

Can you clarify what this means?

justinbmeyer commented 7 years ago

@christopherjbaker this might already be done for can-list. We might need something similar for DefineList.

christopherjbaker commented 7 years ago

It is currently depending on can-list@^3.0.0, but there are 2 failing tests: "sorting works with comparator added after a binding" and "removing comparator tears down bubbling". Though it is probably a simple fix, attempts to track down why have so far alluded me. Should the fixing of this one and the creation of one for DefineList be separate issues?