search

canjs / can-route

Observable front-end application routing for CanJS.
https://canjs.com/doc/can-route.html
MIT License
10 stars 4 forks source link

An in-range update of can-map is breaking the build 🚨 #159

Closed greenkeeper[bot] closed 6 years ago

greenkeeper[bot] commented 6 years ago

☝️ Greenkeeper’s updated Terms of Service will come into effect on April 6th, 2018.

Version 4.0.1 of can-map was just published.

Branch Build failing 🚨
Dependency can-map
Current Version 4.0.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

can-map is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build could not complete due to an error [Details](https://travis-ci.org/canjs/can-route/builds/347391056?utm_source=github_status&utm_medium=notification)
Release Notes 4.0.1

Fixes a couple of issues:

  • canReflect.setKeyValue was used to set a can-compute value instead of canReflect.setValue
  • #91

🎉

Commits

The new version differs by 5 commits.

  • ac24cbe 4.0.1
  • cb08f33 Merge pull request #90 from canjs/set-value
  • ecf35de Merge pull request #92 from canjs/prodefaults
  • 4182fae Use prototype properties as defaults
  • 7adf875 Use setValue instead of setKeyValue with a compute

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 6 years ago

After pinning to 4.0.0 your tests are passing again. Downgrade this dependency 📌.

phillipskevin commented 6 years ago

this passed after re-running.