canjs / can-stache

Live binding handlebars templates
https://canjs.com/doc/can-stache.html
MIT License
10 stars 13 forks source link

Issue with ordering of for/let/converters causing tests to fail #643

Closed Mattchewone closed 5 years ago

Mattchewone commented 5 years ago

When resetHelpers was being called it was removing helpers and causing tests to fail due to the tests running in a different order once a failure had happened.

Changes

for and let are now created as part of builtInHelper as they were being removed when __resetHelpers was run and was causing lot's of failures when the order

I also moved most of helpers/converters into core, so that it can be created in the same way as helpers. So that when __resetHelpers is run throughout tests all the helper and converters are added correctly and won't cause tests to fail due to missing helpers.