search

canjs / can-stream-kefir

Stream values into and out of computes
https://canjs.com/doc/can-stream-kefir.html
MIT License
3 stars 2 forks source link

Update package.json #41

Closed frank-dspeed closed 7 years ago

frank-dspeed commented 7 years ago

Updated dependencys dedupes package versions

chasenlehara commented 7 years ago

Hey @frank-dspeed, I just merged https://github.com/canjs/can-stream-kefir/pull/36 so Greenkeeper should submit PRs to update this project’s dependencies. Thanks for catching all of the dependencies that are still on pre-release versions.

frank-dspeed commented 7 years ago

@chasenlehara i am not sure if that works as you expect it but if it works its ok. I keep that open till i see a version of can-stream-kefir with current packages and will upgrade packages my self till that lands thanks for taking care :+1:

frank-dspeed commented 7 years ago

@chasenlehara importent if we talk about this at same time we should talk about https://github.com/canjs/can-stream as this has the same issues and we get wrong packages there else that are buggy and outdated

frank-dspeed commented 7 years ago

@chasenlehara and lets not forget "can-define-stream": "git+https://github.com/frank-dspeed/can-define-stream.git#patch-1",

frank-dspeed commented 7 years ago

@phillipskevin no it don't installed the later dependencys thats why i forked and updated this.

chasenlehara commented 7 years ago

Thanks @frank-dspeed! This’ll be released next week (I don’t have permission on npm to release this package).

frank-dspeed commented 7 years ago

@chasenlehara :+1: but please don't forget the other related repos situation is exactly the same and i need near same versions i think that logical :)

phillipskevin commented 7 years ago

@chasenlehara, I added you to this one in NPM also.

@frank-dspeed, I'm not sure why it's not installing the latest in your project. Make sure you have the latest minor version listed for anything that is < 1.0. For example, if you have "can-stream": "^0.2.0" you will not get can-stream@0.3.0 which will cause dependency problems.

I don't think this module alone is the problem. Here are the dependencies that get installed prior to this Pull Request being merged:

can-stream-kefir@0.3.0 /home/kevin/dev/can-stream-kefir
├── can-compute@3.3.0
├── can-define@1.3.2
├── can-event@3.5.0
├── can-observation@3.3.0
├── can-stream@0.3.0
├── can-util@3.9.4
├── done-serve@1.3.0
├── donejs-cli@1.0.2
├── generator-donejs@1.0.6
├── jshint@2.9.5
├── kefir@3.7.2
├── steal@1.5.4
├── steal-qunit@1.0.1
├── steal-tools@1.3.6
└── testee@0.5.1

All of these are >= than the versions that are specified in the package.json now (aside from testee).

frank-dspeed commented 7 years ago

@phillipskevin i am sure it was because the pre tag is not valid semver

chasenlehara commented 7 years ago

This has been released in v0.3.1. Thanks again @frank-dspeed!