search

canjs / can-stream-kefir

Stream values into and out of computes
https://canjs.com/doc/can-stream-kefir.html
MIT License
3 stars 2 forks source link

Confusing Maybe Bug double use of can-stream #6 #42

Closed frank-dspeed closed 7 years ago

frank-dspeed commented 7 years ago

can-stream takes (streamInterface) but can-stream-kefir for example already exports can-stream()

const streamInterface = require('can-stream-kefir') //-> module.exports = canStream(canStreamKefir);
const canStream = require('can-stream')
canStream(streamInterface)

so we double wrapp canStream? as the export of can-stream-kefir is already canStream(canStreamKefir) and we pass that into can-stream again?

same issue as: https://github.com/canjs/can-stream/issues/6 was not sure where we correct that but i think removing can-stream from this and removing kefir from can-stream is right

frank-dspeed commented 7 years ago

can be closed totall refactor needed