search

canjs / can-stream

Stream values into and out of computes
https://canjs.com/doc/can-stream.html
MIT License
2 stars 1 forks source link

Confusing Maybe Bug double use of can-stream #6

Closed frank-dspeed closed 7 years ago

frank-dspeed commented 7 years ago

can-stream takes (streamInterface) but can-stream-kefir for example already exports can-stream()

const streamInterface = require('can-stream-kefir') //-> module.exports = canStream(canStreamKefir);
const canStream = require('can-stream')
canStream(streamInterface)

so we double wrapp canStream? as the export of can-stream-kefir is already canStream(canStreamKefir) and we pass that into can-stream again?

Same issue as: https://github.com/canjs/can-stream-kefir/issues/42 was not sure where we correct that but i think removing can-stream from can-stream-kefir and removing kefir from can-stream is right

frank-dspeed commented 7 years ago

@justinbmeyer please look at this as your probally the most skilled with streams at present

when you verifyed it i will make pull request you don't need to handle that only want verification

frank-dspeed commented 7 years ago

Ok i investigated today into all stream related packages and found out that it needs complet refactor to make this idea work as it should