Closed phillipskevin closed 7 years ago
Let's have an encoding that works then.
Sent from my iPhone
On Jul 30, 2017, at 5:13 PM, Kevin Phillips notifications@github.com wrote:
For canjs/can-stache-bindings#229, we need to be able to have properties like on:someMethod="someProp" work. We need to handle this here: https://github.com/canjs/can-util/blob/master/dom/attr/attr.js#L507 to prevent errors:
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
Ok, I think that makes sense. Do you also want to revisit how we're encoding spaces? Spaces only work currently because it goes through this code to use setAttributeNode
, which makes dom/attr
have some specific code for our binding syntaxes.
This was handled by https://github.com/canjs/can-view-parser/releases/tag/v3.5.0.
For https://github.com/canjs/can-stache-bindings/issues/229, we need to be able to have properties like
on:someMethod="someProp"
work. We need to handle this here: https://github.com/canjs/can-util/blob/master/dom/attr/attr.js#L507 to prevent errors: