canjs / can-util

Essential utilities used by lots of CanJS's projects.
https://canjs.com/doc/can-util.html
MIT License
10 stars 8 forks source link

Get skipped tests passing #320

Closed andrejewski closed 7 years ago

andrejewski commented 7 years ago

Some tests where being skipped when window.eventsBubble was false, the problem is the ordering of tests meant it was never true.

Note that these tests should be re-evaluated as to whether they are necessary and inline with the scope of current concerns.

bgando commented 7 years ago

Most recent failing build before skips were added: https://travis-ci.org/canjs/can-util/builds/260327357

Windows 10 internet explorer 11.0

Sauce Labs Job: https://saucelabs.com/jobs/43a5f6dbbcef4094924f6f152f9b3f32 image

Passed: false (358 / 361)

OS X 10.11 safari 10.0

Sauce Labs Job: https://saucelabs.com/jobs/88ee92e81cac43bc8c0073325fb6b8bf image

Passed: false (359 / 363)

Failing test: https://github.com/canjs/can-util/blob/30272b5c7eb3f3239bf9ec69379b7ee85675f45f/dom/attr/attr-test.js#L678-L739

iPhone 7 Simulator iOS 10.0 Safari

Sauce Labs Job: https://saucelabs.com/jobs/6a176acdc57e49eeb6aeb52f9f933dec image

Passed: false (358 / 359) Failing Test: https://github.com/canjs/can-util/blob/30272b5c7eb3f3239bf9ec69379b7ee85675f45f/dom/mutate/mutate-test.js#L63-L82

bgando commented 7 years ago

Windows 10, IE 11, cannot reproduce error:

image image

OS X 10.11 safari 10.0, can reproduce the attr/mutate error only

https://saucelabs.com/beta/tests/c91b8ed4785a46569b33f737f6224375

iPhone 7 Simulator iOS 10.0 Safari, can reproduce the attr/mutate error only

https://saucelabs.com/beta/tests/4d84bd9ede8e4b5495838f5bdb69b581

bgando commented 7 years ago

This issue will become part of a bigger re-organization of can-util's testing strategy.