canjs / can-util

Essential utilities used by lots of CanJS's projects.
https://canjs.com/doc/can-util.html
MIT License
10 stars 8 forks source link

remove use of setAttributeNode #367

Open phillipskevin opened 7 years ago

phillipskevin commented 7 years ago

Since attributes are being encoded now, we should remove the use of setAttributeNode. This was done in https://github.com/canjs/can-util/pull/365 and reverted because some tests were failing in the canjs suite with this change.

We should fix the tests to make this work and revert this revert. I think all that might need to be done is to encode * so that <my-component *viewModel> will work. This was actually done in https://github.com/canjs/can-attribute-encoder/pull/7 also, so that could be re-opened.