Closed m-mujica closed 4 years ago
All tests passing finally!
You shouldn't need to use static getters for
props
andview
since this is only used in Chrome.
Tests won't run if we use static class properties instead of getters because of steal :(
@phillipskevin took care of most of the feedback except the indentation stuff... I'm going to merge 💥
All components are upgraded at this point and the component tests are passing as well.
~I am still working on injected-script-test...~
~Ran the codemod but some manual updates are still required.~ ~There is a test marked with
.only
, that is the last one I was debugging. I found an issue in can-observable-array~~There is also a branch in can-devtools-components with some minor updates needed to get this repo's test passing (like missing exports)~