cankurttekin / PinIt-Gnome-Extension

Pin your notes as notification.
https://extensions.gnome.org/extension/7083/pin-it/
GNU General Public License v3.0
2 stars 0 forks source link

Latest update from Gnome extensions broke the previous fix #2

Open in4matix opened 5 days ago

in4matix commented 5 days ago

Hey, I uninstalled the extension and re-installed it again from the Gnome extensions website, but the white theme with unreadable text issue is persistent?

339204108-c16c85e0-6954-4c7c-854d-93941ae0a05f

Ubuntu 22.04 LTS (Gnome 42.9)

in4matix commented 5 days ago

The version that it updated to is v4. I tried a manual installation, now have below:

s2

But my shell theme is dark?

Maybe it is the theme I'm using? Because on a Ubuntu 22 VM with Yaru Dark theme, it looks correct:

s4

cankurttekin commented 5 days ago

@in4matix hey i couldnt update the extension on gnome page, i was a bit busy lately, it might not be the best to use the one on github. I will check today. For the dark mode, it works by getting color-scheme from gnome.interface and if that value includes "dark" it changes to dark mod. So if your third party theme change your desktop interface to darker colors but keep color-scheme as light this might be the issue. Can you paste this to your terminal and post your output here $ gsettings get org.gnome.desktop.interface color-scheme (this will display your color scheme value)

in4matix commented 4 days ago

Hey, no worries. It amazes me that such a small Application can do so much !! The one from the Gnome website is an old version, ver 4 and the one from Github is ver 8... Anyway, here is what I get in terminal:

daniel@dkdt:~$ gsettings get org.gnome.desktop.interface color-scheme
'prefer-light'
daniel@dkdt:~$

But my shell theme is dark and my Applications theme is light?

Screenshot from 2024-06-26 16-14-15 Screenshot from 2024-06-26 16-15-48

Maybe a setting to set the theme manually?

cankurttekin commented 4 days ago

@in4matix

i forgot to ask, can you also provide gtk-theme with this command: gsettings get org.gnome.desktop.interface gtk-theme

The one from the Gnome website is an old version, ver 4 and the one from Github is ver 8...

Version 5+ for Gnome 45 and 46 Version 1-4.+ for older gnomes. you probably dont see version 5+ available on gnome.extensions because your system is 42.9.

Maybe a setting to set the theme manually?

I dont want to add theme setting to extension as i want to keep it as clean looking as possible and also dont want to make it permanently dark as i never use dark mode. Will find a better solution i might both check gtk theme and color scheme if one of them has dark in its name that should be accepted.

in4matix commented 4 days ago

@cankurttekin , Here is terminal output:

daniel@dkdt:~$ gsettings get org.gnome.desktop.interface gtk-theme
'WhiteSur-Glassy-Light-blue'
daniel@dkdt:~$

This is the version number in Extension Manager:

PinIt-version

cankurttekin commented 4 days ago

So, i cant get any name from your system. If i check for light i will get light mode from 'WhiteSur-Glassy-Light-blue' but theme developer made it look dark. Solution to this will conflict on others system who use stock or properly named themes. I added settings page for image I dont know if this will solve your problem, you will get probably white input fields from 'WhiteSur-Glassy-Light-blue' but dark dialog window if you choose 'Dark' option instead of 'Follow system'. But also you may try editing css file as you wish if you know how to do it

in4matix commented 3 days ago

I dont know if this will solve your problem, you will get probably white input fields from 'WhiteSur-Glassy-Light-blue' but dark dialog window if you choose 'Dark' option instead of 'Follow system'.

Good guess, about the white input fields being white regardless of which theme is selected. But all my other extensions that use input fields, e.g. ArcMenu, work correctly...

But also you may try editing css file as you wish if you know how to do it

Can you maybe point to the line numbers that is responsible for handling input fields?