search

cannawen / dota-gsi-discord-bot

Use Dota 2's Game State Integration API to make helpful announcements in a discord voice channel
MIT License
5 stars 2 forks source link

[bug] are buy a tp scroll/spend gold reminders working #131

Closed cannawen closed 1 year ago

cannawen commented 1 year ago

Yep, this was a problem with the library parsing canCast as can_cast incorrectly.

Fixed in: https://github.com/cannawen/node-gsi/commit/4e0ca206efe214b0a3809f27da190fe6dede0339 https://github.com/cannawen/dota-gsi-discord-bot/commit/bdb49c4d3242522445363ad9cede4970b43c209f

cannawen commented 1 year ago

Broken Aug 9th (9 days ago) from this commit - 45bbf581eb9f48a0a5880053cf192853dc1f945b

Took quite a while to realize there was a bug (after playing and realizing I didn't have a tp scroll, wtf, why didn't my bot warn me?!) ... is there some better process that can be implemented to improve this bug discovery? Do refactors need to be more thoroughly tested before pushing to master?

There were unit tests that passed, but the tests were not reflective of reality. If we ran the integration test scenario (npm run dig-canna) it would have caught the problem. Gotta be more careful next time to run the integration tests!