search

cannawen / dota-gsi-discord-bot

Use Dota 2's Game State Integration API to make helpful announcements in a discord voice channel
MIT License
5 stars 2 forks source link

[bug] trying to start coaching session multiple times #133

Closed cannawen closed 10 months ago

cannawen commented 11 months ago

Fish & wrath were playing in a game together, both had autoconnect on to the same guild.

This was being spammed multiple times, consistently restarting Fish's coaching session (probably on every GSI call).

2023-08-22T00:45:14.515 app[e2865644f6e686] yyz [info] 2023-08-22 00:45:14 info [APP] Start coaching student d2cdf227e5

2023-08-22T00:45:15.484 app[e2865644f6e686] yyz [info] 2023-08-22 00:45:15 info [APP] Deleting old coaching session for student d2cdf227e5

2023-08-22T00:45:15.484 app[e2865644f6e686] yyz [info] 2023-08-22 00:45:15 info [APP] Deleting session for student d2cdf227e5

2023-08-22T00:45:15.484 app[e2865644f6e686] yyz [info] 2023-08-22 00:45:15 info [APP] Start coaching student d2cdf227e5

2023-08-22T00:45:16.518 app[e2865644f6e686] yyz [info] 2023-08-22 00:45:16 info [APP] Deleting old coaching session for student d2cdf227e5

2023-08-22T00:45:16.518 app[e2865644f6e686] yyz [info] 2023-08-22 00:45:16 info [APP] Deleting session for student d2cdf227e5

2023-08-22T00:45:16.519 app[e2865644f6e686] yyz [info] 2023-08-22 00:45:16 info [APP] Start coaching student d2cdf227e5

The app restarted due to out-of-memory error. And then wrath's coaching session started going crazy with the restarts

Probably a regression introduced in the last refactor 8f599e243ac6f024700af45de67bdbd68afcee03

cannawen commented 11 months ago

Crashed twice during Monday stack's gaming session

Image

cannawen commented 11 months ago

Fixed in theory, but we'll wait until Monday to see if Monday stack breaks it again.

cannawen commented 10 months ago

Bot is no longer crashing, which is cool. Still some weird UX issues with multi-person autoconnect, opened #136 to track