search

cannawen / dota-gsi-discord-bot

Use Dota 2's Game State Integration API to make helpful announcements in a discord voice channel
MIT License
5 stars 2 forks source link

[chore] Refactor so FactStore handles returning default value instead of Engine #144

Closed cannawen closed 6 months ago

cannawen commented 6 months ago

Topic has a defualt value field, so it makes sense for us to handle it at the DB level ...

Or does it? It is different if a user explicitly writes "use default" vs if the user writes "save this value who just happens to be the same as the default value" ... Okay...

cannawen commented 6 months ago

Need to investigate if such a change is a good idea/the implications of such a change

cannawen commented 6 months ago

I don't think it is good to make this change. There is indeed a difference between "this assistant is by default public" and "I want to change this assistant to always play public audio" ... when the assistant's programatic default changes to private, scenario 1 should change to private but scenario 2 should remain as public.

I think I made this revelation some time ago as well, but not sure where it is documented? Oh well. Closing issue as won't fix