cannawen / dota-gsi-discord-bot

Use Dota 2's Game State Integration API to make helpful announcements in a discord voice channel
MIT License
5 stars 2 forks source link

[chore] roshan killed times array in roshan assistant is incorrect #63

Closed cannawen closed 1 year ago

cannawen commented 1 year ago

The "event" lasts for multiple time ticks so the roshan killed time array has seconds [100, 101, 102] for example . This means our rosh death count will be incorrect

We should probably use the game time to figure out the actual clock time that roshan has died

cannawen commented 1 year ago

This was incidentally fixed when we separated the trigger and the givens arrays.

We are only triggering saving rosh death time on new events now; everything should be working fine