WIP - Conversion refactor proof of concept - Githubissues

cannawen / metric_units_reddit_bot

Reddit bot converting imperial units to metric units

https://www.reddit.com/user/metric_units

GNU General Public License v3.0

78 stars 34 forks source link

WIP - Conversion refactor proof of concept #101

Closed cannawen closed 6 years ago

cannawen commented 6 years ago

Brief description of changes:

This is a WIP/proof of concept
Pulled 3 conversion into their own separate file

Downside: They used a lot of shared functions, so I created a "shared" thing (final name TBD) so we can pull functions from it

TODO:

Create "default" values so we do not need to write "isZeroOrNegative" or "isHyperbole" all the time
Refactor to dynamically generate a list of all regexes, instead of putting everything in a hard-coded array

Reviews welcome. Is this generally the direction we want to go in?

Relevant link(s):

Related to: #87