cannawen / metric_units_reddit_bot

Reddit bot converting imperial units to metric units
https://www.reddit.com/user/metric_units
GNU General Public License v3.0
78 stars 34 forks source link

Add test coverage statistics #104

Closed chazzlabs closed 6 years ago

chazzlabs commented 6 years ago

PR Checklist

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling 0222bede7b1371c858c1c955ea1e800c9416b9be on chazzlabs:master into on cannawen:master.

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling 3d06aafcba41ec56f0a7c68c579e535020d56488 on chazzlabs:master into on cannawen:master.

chazzlabs commented 6 years ago

@cannawen This should be good to go now. And it looks like the coverage went up! 😄

cannawen commented 6 years ago

I'm a bit confused with the "files changed", it looks like somehow a bunch of other commits got into PR ... uhhh.... any idea how to fix it? If we squash-merge the PR in, would it look ok on master?

chazzlabs commented 6 years ago

@cannawen That's strange. Could it be because I did a git rebase? If you look at the commits in this PR it also lists all of my relevant commits twice which also confuses me. I'm not sure about the squash merge suggestion; I've never used squash before.

nalinbhardwaj commented 6 years ago

Better to fast forward the branch first to prevent unwanted changes. @cannawen

cannawen commented 6 years ago

Maybe this will fix it @chazzlabs?

Check out your master branch git reset --soft cf369d6 make a branch git commit -m "Add test coverage statistics" make sure the commit looks ok and you haven't lost any code git push -u origin branch make a PR of that branch

There's also probably some rebase -i solution but interactive rebases confuse me :rofl:

coveralls commented 6 years ago

Coverage Status

Changes Unknown when pulling 9e2b796e96b72ad468e7f19fe986b365ff5c325a on chazzlabs:master into on cannawen:master.