Closed chazzlabs closed 6 years ago
@cannawen This should be good to go now. And it looks like the coverage went up! 😄
I'm a bit confused with the "files changed", it looks like somehow a bunch of other commits got into PR ... uhhh.... any idea how to fix it? If we squash-merge the PR in, would it look ok on master?
@cannawen That's strange. Could it be because I did a git rebase
? If you look at the commits in this PR it also lists all of my relevant commits twice which also confuses me. I'm not sure about the squash merge suggestion; I've never used squash before.
Better to fast forward the branch first to prevent unwanted changes. @cannawen
Maybe this will fix it @chazzlabs?
Check out your master
branch
git reset --soft cf369d6
make a branch
git commit -m "Add test coverage statistics"
make sure the commit looks ok and you haven't lost any code
git push -u origin branch
make a PR of that branch
There's also probably some rebase -i
solution but interactive rebases confuse me :rofl:
PR Checklist
closes #{issue number}
if appropriateAdded Coveralls code coverage. A new npm script,
cover
, was added which runs Istanbul on the results of the Mocha unit test runner and generates coverage reports. This script is run after a successful TravisCI build, and results are reported by Coveralls.Relevant link(s):
Resolves #56.