Closed pdbeard closed 6 years ago
@citricsquid If I continue to make changes to my fork will they automatically be added to my pull request if it hasn't been accepted yet?
@pdbeard Yes, if you're making changes to the same branch (master
) as the branch that you created your Pull Request from (master
) then those changes will be automatically included in this Pull Request.
I kept the guide very simple so I skipped explaining branches, but usually, when working on a project like this you'd create a new branch for each contribution (e.g: for this, you might have created a branch called time-wasted-sass
). If you want to work on another feature while you're waiting for this Pull Request to be accepted you should create a new branch, as commits to that branch won't be included here :)
The instructions for creating a new branch depend on how you're using git (desktop client, via the website, or command line). If you need any more pointers, let me know.
Is there anything else that needs to be added, or is this PR good to merge? cc @citricsquid @pdbeard
Looks good to me.
PR Checklist
closes #{issue number}
if appropriateAdds a snarky reply when a users edits a comment to no longer include values that can be converted.
Relevant link(s):
Resolves #90