Conversion refactor folders

cannawen commented 6 years ago

PR Checklist

[x] I have read the Contributing Guidelines
[x] New functionality (or bug fix) is appropriately tested
[x] PR includes closes #{issue number} if appropriate
- Breaks out each conversion into its own file, organized by category
- The files starting with _ (i.e. _velocity.js) hold shared functions for the category
- Files titled {{unit}}.js are very similar to elements in the unitsLookupList array in conversion_helper.js
- There is probably more refactoring to be done, this is just a first pass. Please help identify areas that can be further refactored by commenting on the PR!
Feedback welcome, if anyone has other ideas on how to break up our monolithic conversion_helper.js

Relevant link(s):

Closes #87

coveralls commented 6 years ago

Coverage increased (+1.6%) to 92.498% when pulling 6bea34e2e68344c05c367c527286d1e91a300896 on conversion-refactor-folders into ff128712dd2b1921fbfa44293d1e89f839b80449 on master.

coveralls commented 6 years ago

Coverage increased (+1.6%) to 92.483% when pulling f81f0c83d9a486c44f29b958938baa83695e508a on conversion-refactor-folders into ff128712dd2b1921fbfa44293d1e89f839b80449 on master.

cannawen commented 6 years ago

Alright, in it goes. Feel free to leave more comments on the PR for minor things, or open a new issue to discuss any concerns.

cannawen / metric_units_reddit_bot

Conversion refactor folders #114

PR Checklist

Relevant link(s):