search

cannawen / metric_units_reddit_bot

Reddit bot converting imperial units to metric units
https://www.reddit.com/user/metric_units
GNU General Public License v3.0
78 stars 34 forks source link

Increase threshold for light seconds conversion #47

Closed cannawen closed 6 years ago

cannawen commented 6 years ago

metric_units is a sassy reddit bot that finds imperial units, and replies with a metric conversion.

Enhancement request: Light seconds are used too liberally. Change code so that >2 million miles are converted to light seconds. See this file to get started

Recommended skills: Basic javascript Estimated time: 20 minutes

Comment below if you would like to take on this task!

cmd-kvn commented 6 years ago

I'd like to take this task @cannawen!

cannawen commented 6 years ago

Sounds good! Let me know if you need any assistance getting started :)

cmd-kvn commented 6 years ago

I appreciate the offer. I do have a beginner's question: it's required to sign up for a Reddit account to do testing? That's the only way to make the .yaml file?

cannawen commented 6 years ago

Just straight up copy the sample-environment file without changing any values, you don't need a reddit account to run "npm test". I will update the README file to make the instructions more clear :) Thanks!

cmd-kvn commented 6 years ago

Wonderful! It's all sorted and I have the ability to test. I'll start my attempt at the code. Thank you!

cannawen commented 6 years ago

Oops wait, it looks like someone else already made a PR on this story @cmd-kvn ... would you like to pick up a different story? Sorry I didn't notice this earlier (it's hard to keep track with all the stories and PRs flying around), there's definitely some process improvements needed.

cmd-kvn commented 6 years ago

I appreciate the update and I understand, @cannawen. I'll just check in on the issues when I have time and try my luck again.

cannawen commented 6 years ago

@cmd-kvn I added a whole bunch of new issues (not tagged hacktoberfest yet) if you are still interested in contributing :) Again, sorry for the confusion! I'm working on writing out the project's processes so this won't happened again in the future

cmd-kvn commented 6 years ago

@cannawen you are bomb.com. I would be happy to take a look!