search

cannawen / metric_units_reddit_bot

Reddit bot converting imperial units to metric units
https://www.reddit.com/user/metric_units
GNU General Public License v3.0
78 stars 34 forks source link

Keywords that should be trigger a "fl oz" translation instead of "oz" #54

Closed cannawen closed 6 years ago

cannawen commented 6 years ago

Related to #43 and #52

Missing: "cup", "breastfeeding", "cans", "tall boy", "brew"

cannawen commented 6 years ago

Ah, I shouldn't have closed this. Of course there is more.

"pint", "bartending", "Flow improver", medium, paint, retarder, thinner, primer, wash, acrylic, paste, oil,

ajripley commented 6 years ago

Is this still available to fix? I didn't see changes addressing "pint" and "bartending" in the main branch or in any of the pull requests. I'd love to give it a shot, if it's up for grabs. :)

nalinbhardwaj commented 6 years ago

@ajripley yep, feel free to make a PR adding the two words. :)

ajripley commented 6 years ago

@nalinbhardwaj I assumed that there would be more work - are there no tests for this that would need updating?

I suppose if it's that simple, it should probably go to someone who hasn't made a pull request before.

nalinbhardwaj commented 6 years ago

@ajripley the issue will probably be kept open for a while as there'll be more keywords we'd be missing.