cannawen / metric_units_reddit_bot

Reddit bot converting imperial units to metric units
https://www.reddit.com/user/metric_units
GNU General Public License v3.0
77 stars 34 forks source link

Square inches should be converted to metric areas #57

Closed cannawen closed 7 years ago

cannawen commented 7 years ago

metric_units is a sassy reddit bot that finds imperial units, and replies with a metric conversion.

Current behaviour:

  1. Acres are translated to metric areas, but square inches are not.
  2. Metric areas include m^2, hectares, and km^2

Enhancement request:

  1. inches^2 should be converted to metric areas
  2. cm^2 should be one of the metric area options

See this commit for an example of how to add a new conversion

Recommended skills: Basic javascript & basic regular expressions

Estimated effort: 30 minutes

Comment below if you would like to take on this task!

joshuaj1397 commented 7 years ago

Hi, I can tackle this issue! :D

cannawen commented 7 years ago

Sure thing, thanks! Feel free to reach out if you need any assistance :)

cannawen commented 7 years ago

Hey @joshuaj1397 we have just added a CONTRIBUTING.md doc, please check it out when you have time! Sections "Etiquette", "Work on an issue" and "Make a PR" are most important

joshuaj1397 commented 7 years ago

Will do, thanks!

cannawen commented 7 years ago

Closing due to inactivity. Perhaps we can re-open it after we have refactored how all conversions are handled