Closed cannawen closed 6 years ago
@cannawen I'm finally getting some time this week to make progress on #28! Should be done fairly soon and submitted for review so we can get to adding more personality. 💃
This one's great by the way!
No worries, take your time :D
I can't take any credit for the idea, someone suggested it on reddit
Marking as unblocked on #28. I just realized this takes a completely different code path than our regular personality triggers.
@cannawen This thought didn't cross my mind, but you're totally right. We'd have to handle this as a conversion. Should this be as simple as the other conversions or does the special case make this more complex?
I am OK with it being a hard-coded special case (kind of like the subreddit /r/totallynotrobots is a special case). If we get too many of these "hard coded special case" scenarios, we can look into doing another refactor but I think 2 is acceptable for now.
Assigning to @sirugh
You could still possibly use the personality.js code if you follow similar instructions to #90 :) up to you though, whatever you think makes the most sense!
@cannawen can you assign this to someone else? I started getting into it but I feel like I'd rather refactor the bot code before just adding this sort of thing -- and I think you've already got some helpers on the overhaul/refactor. Enjoy the precommit hook :) Take care!
OK Thanks! :)
Closing for inactivity - Perhaps a future enhancement to look into
When the bot sees "I would walk 500 miles" it should respond "And I would walk 804.672km more" (or other similar joke responses)
This is more complex than adding a standard personality, because this relies on new comments and not comment replies.