search

cannawen / metric_units_reddit_bot

Reddit bot converting imperial units to metric units
https://www.reddit.com/user/metric_units
GNU General Public License v3.0
78 stars 34 forks source link

Closes issue#79 #80

Closed namantw closed 6 years ago

namantw commented 6 years ago

PR Checklist

namantw commented 6 years ago

Hey @cannawen I have corrected the errors in PR.

cannawen commented 6 years ago

Cool, thanks for the changes!

One small note:

The reason it's generally good practise to included "close {issue number}" is so that github automagically closes the linked issue. See this PR for example, if you hover over the word "closes" with your mouse, github gives you a popup saying that the issue will be closed once the PR is merged in.

Can you change your description to say "closes #79" (without the word "issue")? It seems very pedantic I know, but it helps keep the PRs and Issues linked in an open source project :)

namantw commented 6 years ago

It is amazing that I got to learn so much from my first PR, all thanks to you :) @cannawen I have corrected it :)

cannawen commented 6 years ago

Yay, I'm glad you found the experience a positive one! Thank you for contributing :D

Your fix will be in the v0.11.9 release, and I will add you to the "contributors" grid shortly.