Closed namantw closed 6 years ago
Hey @cannawen I have corrected the errors in PR.
Cool, thanks for the changes!
One small note:
The reason it's generally good practise to included "close {issue number}" is so that github automagically closes the linked issue. See this PR for example, if you hover over the word "closes" with your mouse, github gives you a popup saying that the issue will be closed once the PR is merged in.
Can you change your description to say "closes #79" (without the word "issue")? It seems very pedantic I know, but it helps keep the PRs and Issues linked in an open source project :)
It is amazing that I got to learn so much from my first PR, all thanks to you :) @cannawen I have corrected it :)
Yay, I'm glad you found the experience a positive one! Thank you for contributing :D
Your fix will be in the v0.11.9 release, and I will add you to the "contributors" grid shortly.
PR Checklist
closes #79
if appropriateAdded a flag 'gi' in line 375 so that regular expression ignores the cases.
Relevant link(s):
closes #79