cannawen / metric_units_reddit_bot

Reddit bot converting imperial units to metric units
https://www.reddit.com/user/metric_units
GNU General Public License v3.0
78 stars 34 forks source link

Conversions architecture overhaul #87

Closed cannawen closed 6 years ago

cannawen commented 6 years ago

Similar to #28, our conversions file is getting out of hand. Consider refactoring so that each conversion's data is in a .yaml file

Consider using the regex length to sort the order of conversions, so "miles per hour" (14 char) will get triggered before "miles" (5 char).

Maybe we should stop adding new conversions, until this refactor is in place?

This issue is open for discussion on reddit