Closed cmd-kvn closed 6 years ago
Hey @cmd-kvn this looks great! Yes, if you could open a separate PR for the nfl one that would be much appreciated :) Thank you so much!! (And sorry for the confusion about the team name vs. subreddit name thing in the Issue)
I'm not exactly sure what the package.lock file is, but Google says it's good to commit XD
@cannawen I believe the package.lock is something that gets generated after I run an npm install
. Glad it's not hurting anything XD.
No need to apologize for the confusion! I'm glad the discussion clarified things :)
PR Checklist
closes #{issue number}
if appropriateThe subreddit names of 30 NBA teams have been added to the
ignoredKeywords
in theobject
relating to mpg within theunitLookupList
array
. Tests are not included because it appears tests already exist, just not for the specific key words I added:I am also curious if this means #39 needs to be fixed. Some NFL subreddit names do not match the NFL team name that's in the ignoredKeywords. I'd be happy to fix that if that is the case.
Relevant link(s):
Closes #81