cannod / moodle-drupalservices

Moodle plugin to connect to Drupal services
36 stars 25 forks source link

Drupal 7 / Moodle 3 Plugin (aka 3.x-1.x-dev) #77

Open websiteexpress opened 7 years ago

websiteexpress commented 7 years ago

Hi, we needed a Drupal 7 / Moodle 3 version for a client, so we took your 3.x-2.x-dev branch and made our own 3.x-1.x-dev which is now tested and working.

We'd be happy to contribute this back for anyone else that needs it if you'd like us to?

All the best, James

netw3rker commented 7 years ago

That's awesome! Let's get this into a pull request and I'll take a look!

One thing to note, we currently are rolling out our 3.x-3.0 line for d8 only, and this comes with a very large rewrite of the plugin that likely won't be directly upgradable.

Depending on what you've done here, we could get a 3.x-2.x line going too.

websiteexpress commented 7 years ago

Hi netw3rker,

Done - please see this pull request: https://github.com/cannod/moodle-drupalservices/pull/78

All the best, James

monishdeb commented 6 years ago

I have configured this plugin for Drupal7.59 + Moodle and applied the patch #78. But now I am always getting cookie for anonymous user at moodle end where it suppose to fetch the cookie for authenticated user. I have checked my config as many time as I can but didn't found any miss. My Drupal site is at https://cooperativenewschool.com and moodle at https://learn.cooperativenewschool.com and $cookie domain='.cooperativenewschool.com'

Am I missing something here?

websiteexpress commented 6 years ago

Hi Monishdeb,

I'm afraid the project we did this work for migrated to another platform a few months, so we don't have a testing platform for it anymore.

The code was working fine in production for many months.

Please check that you have set the cookie domain to the same main domain in both Drupal and Moodle configurations - in any admin screens and you are using the same protocol - we enforced https only.

Good luck, James

monishdeb commented 6 years ago

Thanks @websiteexpress for your reply. Yes, I fixed it yesterday by setting the same cookie domain at Moodle config.php which I missed earlier. I think it should be mentioned on the wiki page https://github.com/cannod/moodle-drupalservices/wiki that will be a big help to poor souls who spent hours in figuring out what went wrong. Thanks again for your good work :)

Cheers, Monish

jacq0123 commented 5 years ago

Thanks @websiteexpress for your reply. Yes, I fixed it yesterday by setting the same cookie domain at Moodle config.php which I missed earlier. I think it should be mentioned on the wiki page https://github.com/cannod/moodle-drupalservices/wiki that will be a big help to poor souls who spent hours in figuring out what went wrong. Thanks again for your good work :)

Cheers, Monish

Hi, could you please tell me how you got your Drupal 7 and Moodle 3.x to work? I will really appreciate. Thanks!