search

canonical-web-and-design / build.snapcraft.io

The Snapcraft Build site.
GNU Affero General Public License v3.0
21 stars 26 forks source link

"The snapcraft.yaml can’t be used because it isn’t valid." is a lie #1214

Closed popey closed 5 years ago

popey commented 5 years ago

Summary

build.snapcraft.io says the yaml for wire is not valid and as such I cannot trigger a build. This means I cannot publish an updated build of the snap via build.

The yaml is indeed valid, proved by cloning the repo and building it on my PC.

Process

Visit build.snapcraft.io and sign in Scroll down list of repos See wire and note it's not possible to trigger

Current and expected result

I expect it to allow me to trigger a build.

Screenshot

Screenshot_20190409_151827

popey commented 5 years ago

End of the output from me building that very yaml locally..

Skipping stage gnome (already ran)                                                 
Skipping stage libappindicator (already ran)                                   
Staging wire                                                            
Priming desktop-gnome-platform                                            
Priming gnome                                                                       
Priming libappindicator                                                            
Priming wire                                                                   
Determining the version from the project repo (version-script).                
The version has been set to '3.9.2895'                                          
Snapping 'wire' |                                                                                                                                                                             
Snapped wire_3.9.2895_amd64.snap
bartaz commented 5 years ago

@popey That's online version of validator build.snapcraft uses: http://nodeca.github.io/js-yaml/ It says: 

duplicated mapping key at line 18, column 1:
    grade: stable
    ^

Seems that local snapcraft just ignores that and builds.

I think we have an issue already reported to show validation errors to help solve such issues quicker (found it #668).

bartaz commented 5 years ago

Seems like underlying issue with yaml file was fixed.

As there is a separate issue to track yaml linting and showing better error messages (#668), I'll close this one as a duplicate.