search

canonical-web-and-design / juju-cards

Code base for for juju embedded card system for charm, bundle and profiles.
6 stars 10 forks source link

Bundle fixes #3

Closed marcoceppi closed 8 years ago

marcoceppi commented 8 years ago

This allows personal namespace bundles to load. There's also a small split in the logic. If we have an Owner from the API, we can route the user to the that /u/<owner>'s address. I've opted to follow this when we can determine it as it's a better route than just linking to launchpad.

This also allows embedding from a remote address. In previous versions the head would get a new style for src="scss/style.css" which will fail. It will attempt to resolve from the js/juju-embed.js domain.

marcoceppi commented 8 years ago

QA

  1. gulp build and verify that kubernetes-cluster loads.
  2. Apply 9d26dc3 on top of 481fc63
  3. gulp build, verify that kubernetes-cluster card loads, but svg does not
marcoceppi commented 8 years ago

Honestly, some of the changes to bundle wrt Owner could be applied to charm, but I'm too lazy to bother atm.

anthonydillon commented 8 years ago

Thanks Marco, looks good :+1: