Open richmccartney opened 8 years ago
Why would we offer an option? Shouldn't all themes work offline with a change to the asset path?
On Tue, 11 Oct 2016, 17:26 Richard McCartney, notifications@github.com wrote:
Create the option in the framework to add offline or online assets as the use case for the framework will require this
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ubuntudesign/maas-gui-vanilla-theme/issues/10, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWRnpuNt9j6CC9nBeMnq7YVQN3KXGjFks5qy7ihgaJpZM4KT1NY .
The reason would be if we have a version using the asset server we will get files that have a different naming convention that if they're to be local and offline. Giving the option and pre-made setup for both would be advantageous for any setup.
MAAS for example would not benefit from just changing the asset-path and neither would Landscape as it will have offline and online elements to the system once this has been applied.
In Juju I grab that assets and place them into the image asset directory in the app. Then i change the asset-path to a local path.
How would we know where an sites/apps image directory would be? Is there a case in MAAS that couldn't be solved with the above solution?
On Tue, 11 Oct 2016, 20:24 Richard McCartney, notifications@github.com wrote:
The reason would be if we have a version using the asset server we will get files that have a different naming convention that if they're to be local and offline. Giving the option and pre-made setup for both would be advantageous for any setup.
MAAS for example would not benefit from just changing the asset-path and neither would Landscape as it will have offline and online elements to the system once this has been applied.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/ubuntudesign/maas-gui-vanilla-theme/issues/10#issuecomment-253018352, or mute the thread https://github.com/notifications/unsubscribe-auth/ABWRnnpaWXaAXO5ZOnT7TbV4lRfhaVEgks5qy-JNgaJpZM4KT1NY .
Create the option in the framework to add offline or online assets as the use case for the framework will require this