Update icon library - Githubissues

canonical-web-and-design / maas-gui-vanilla-theme

MAAS GUI Theme. Provides a HTML & CSS Framework to develop the UI of the MAAS app and other projects

http://ubuntudesign.github.io/maas-gui-vanilla-theme/

4 stars 1 forks source link

Update icon library #73

Closed grahambancroft closed 7 years ago

grahambancroft commented 7 years ago

Done

Update icon library with latest VF icons
Add titles to image to make identification easier
Add static images to assets folder

QA

Pull branch, run npm install and gulp build
Go to the demo - demo/index.html#icons to see the changes
Make sure the icons listed in the card have been updated by comparing them to the icons at http://ubuntudesign.github.io/maas-gui-vanilla-theme/#icons

Details

Fixes https://app.zenhub.com/workspace/o/canonicalltd/maas-design/issues/183

kwm14 commented 7 years ago

@grahambancroft could you attach a screenshot of your updates as I'm not able to view the demo. Thanks

grahambancroft commented 7 years ago

@kwm14 Screenshot as requested

screen shot 2017-09-26 at 16 52 10

kwm14 commented 7 years ago

Visual review

remove error outline icon - icon icon--error
remove duplicate tooltip icon, first column third row down - icon icon--tooltip
remove tick outline icon - icon icon--pass

icon-board

grahambancroft commented 7 years ago

@kwm14 Done

screen shot 2017-09-26 at 17 52 54

kwm14 commented 7 years ago

@grahambancroft

You've removed the wrong 'error' icon from the icon set.

[ ] remove error outline icon
[ ] add error fill icon

grahambancroft commented 7 years ago

@kwm14 I removed icon--error which is the one you asked me to remove, I missed the outline bit, power--error is the outline icon, I'll remove that one and get icon--error back in there :)

kwm14 commented 7 years ago

@grahambancroft ok cool. Ah I see that must of had the same class name :)

grahambancroft commented 7 years ago

@kwm14 Done

kwm14 commented 7 years ago

@grahambancroft looking good 👍