search

canonical-web-and-design / practices

Guides and principles from the web team at Canonical and Ubuntu
https://canonical-web-and-design.github.io/practices/
Other
45 stars 30 forks source link

Merge react.md into a generic document about JavaScript guidelines #118

Closed nottrobin closed 5 years ago

nottrobin commented 5 years ago

Rationale here: https://github.com/canonical-webteam/practices/pull/106#discussion_r235654424

actually most of the recommendations in this document should be generalised as JavaScript guidelines - naming of component files and JSX files should probably sit alongside general advice for naming JavaScript files, that advice and advice on Redux could also be applicable in non-React apps. So what should probably happen is that any React-specific advice should form a section in a general document on JavaScript advice.

squidsoup commented 5 years ago

+1, code-formatting.md should also be merged.

squidsoup commented 5 years ago

Fixed in https://github.com/canonical-webteam/practices/pull/123