Closed b-m-f closed 5 years ago
:+1: thanks for this @b-m-f it's great! I'm now very happy with it. Sorry for all the pernickety comments.
:+1: from me!
Looking good. Great work @b-m-f
@b-m-f for future reference, this shouldn't have been merged for another 18 hours:
- A reasonable effort should be made to bring it to the attention of the whole team
- It should also have been +1d by at least 2 team members
- It should have been open for at least 24 hours
A small proposal for a document outlining our practices on writing Python code.
What do you think about the Testing & Documentation blocks?