search

canonical-web-and-design / practices

Guides and principles from the web team at Canonical and Ubuntu
https://canonical-web-and-design.github.io/practices/
Other
45 stars 30 forks source link

Adds document for python coding standards #120

Closed b-m-f closed 5 years ago

b-m-f commented 5 years ago

A small proposal for a document outlining our practices on writing Python code.

What do you think about the Testing & Documentation blocks?

nottrobin commented 5 years ago

:+1: thanks for this @b-m-f it's great! I'm now very happy with it. Sorry for all the pernickety comments.

Caleb-Ellis commented 5 years ago

:+1: from me!

jpmartinspt commented 5 years ago

Looking good. Great work @b-m-f

nottrobin commented 5 years ago

@b-m-f for future reference, this shouldn't have been merged for another 18 hours:

  • A reasonable effort should be made to bring it to the attention of the whole team
  • It should also have been +1d by at least 2 team members
  • It should have been open for at least 24 hours