search

canonical-web-and-design / practices

Guides and principles from the web team at Canonical and Ubuntu
https://canonical-web-and-design.github.io/practices/
Other
45 stars 30 forks source link

Add some general guidelines around PR etiquette #139

Closed barrymcgee closed 5 years ago

barrymcgee commented 5 years ago

Please review the content for spelling, grammar and sanity.

bartaz commented 5 years ago

Good guidelines 👍

nottrobin commented 5 years ago

These look good :+1:. This topic overlaps slightly with the code of conduct stuff mentioned in https://github.com/canonical-webteam/practices/issues/128. When that document exists, it would be good to link to it from this one, and we should obviously make sure the advice doesn't conflict. But that's for the future. :+1: for now.

EDIT: I've now made a couple of points inline, though neither of them are hard blockers.

barrymcgee commented 5 years ago

@nottrobin @bartaz I added an extra point after your reviews which is the only point I think might be contentious... or perhaps not? Either way, have a 👀

nottrobin commented 5 years ago

Thanks @barrymcgee for this great work, and working in my suggestions. This sort of content is exactly the sort of thing I was hoping practices would be about - deep statements about attitude that can help to define our team culture.

I'm very happy with it in its current form. Big :+1: from me. Thanks again!

barrymcgee commented 5 years ago

@nottrobin 🙌🏻