canonical-web-and-design / practices

Guides and principles from the web team at Canonical and Ubuntu
https://canonical-web-and-design.github.io/practices/
Other
45 stars 30 forks source link

Add circleci step to run Prettier #170

Closed barrymcgee closed 5 years ago

barrymcgee commented 5 years ago

Done

As we do not use run Prettier on pre-commit, this change is to run it as a build step instead.

QA

Question

@nottrobin Do we have a shared config for CircleCI tasks?

nottrobin commented 5 years ago

We don't have a "shared" one, but all our circleci configs do follow a similar pattern:

Example

nottrobin commented 5 years ago

So in this case you could have one job called e.g. "check-prettier". And maybe one for "test-site" if you have time.