search

canonical-web-and-design / practices

Guides and principles from the web team at Canonical and Ubuntu
https://canonical-web-and-design.github.io/practices/
Other
45 stars 30 forks source link

Updates merging rule to be less strict on merging from original author #175

Closed b-m-f closed 5 years ago

b-m-f commented 5 years ago

As discussed in the dev catchup it should be possible to merge a PR when everything looks good, even if you are not the original author.

Branch cleanup will be done in the Fork.

barrymcgee commented 5 years ago

Adding do not merge as I'm conscious this was discussed in @nottrobin's absence and previously he was the strongest proponent for the opposite approach.

Let's not merge until he has had a chance to review this change.

nottrobin commented 5 years ago

:+1: once "f.e." is changed to something else

nottrobin commented 5 years ago

:+1: from me

bartaz commented 5 years ago

👍

steverydz commented 5 years ago

:+1: