search

canonical-web-and-design / practices

Guides and principles from the web team at Canonical and Ubuntu
https://canonical-web-and-design.github.io/practices/
Other
45 stars 30 forks source link

Team mantras #209

Closed anthonydillon closed 4 years ago

anthonydillon commented 4 years ago

I have worked on outlining a number mantras I feel are important for the team to agree on when it comes to making UI decisions. Please take time to review the content and suggest improvements.

nottrobin commented 4 years ago

Love these. :+1:. A few comments inline for your consideration, but I'm happy either way.

lilyvidenova commented 4 years ago

I'm sorry if I sound dumb but I have no idea how to see the full file we are supposed to review.

squidsoup commented 4 years ago

I'm sorry if I sound dumb but I have no idea how to see the full file we are supposed to review.

@lilyvidenova You have to click the "Files changed" tab at the top:

image

lilyvidenova commented 4 years ago

I'm sorry if I sound dumb but I have no idea how to see the full file we are supposed to review.

@lilyvidenova You have to click the "Files changed" tab at the top:

image

Thanks @squidsoup! It still took me a long time to figure out how to see the actual text from there.

In more general terms - I think these are a good starting point but are too general. I also don't think this is a good way to have a discussion.

nottrobin commented 4 years ago

@lilyvidenova what do you think is a better way?

There's Google Docs (which is how this started - https://docs.google.com/document/d/1ywsoF9Sp06hxLj4veC2VSHT2kPvJWHionOI1yeCgMAc/edit#) which give you better direct visibility over the document and make it easier to hold discussions on specific lines in comments. Using Google Docs is actually suggested in CONTRIBUTING.md.

Is that what you're thinking of? Or do you think maybe email?

@clagom suggested (by email) a meeting during the planning week. While I think face-to-face discussions and meetings around larger practices are a great idea, and we should definitely do them, I don't think they should make up the entirety of the discussion. I think it's better to have a digital place to centralise the discussion (GitHub, A google doc, an email thread) which we can then have meetings around.

For me there are a number of problems with making all the decisions in the meeting:

So maybe we should move discussion back to the Google doc, and also schedule a meeting for the week after next, and anything that comes out of the meeting can also be used to update the Google doc. What do you all think?

anthonydillon commented 4 years ago

Sorry all, closing this PR and please move the conversation to the google doc.