search

canonical-web-and-design / practices

Guides and principles from the web team at Canonical and Ubuntu
https://canonical-web-and-design.github.io/practices/
Other
45 stars 30 forks source link

Remove navigation requirement from contributing.md #239

Closed nottrobin closed 4 years ago

nottrobin commented 4 years ago

We no longer need the navigation section

anthonydillon commented 4 years ago

Would you mind fixing the CI issue introduced by #238 for bonus points?

nottrobin commented 4 years ago

@anthonydillon how did that get merged? I'm gonna make the prettier check required unless you object.

anthonydillon commented 4 years ago

It was merged by Claudio as he didn't know the process. The check should of course be required.

anthonydillon commented 4 years ago

I've made the checks required

clagom commented 4 years ago

Sorry! @nottrobin @anthonydillon

anthonydillon commented 4 years ago

@clagom not your fault. The system shouldn't have let you make a mistake.

nottrobin commented 4 years ago

@anthonydillon I switched over to github actions at the same time =)