search

canonical-web-and-design / practices

Guides and principles from the web team at Canonical and Ubuntu
https://canonical-web-and-design.github.io/practices/
Other
44 stars 30 forks source link

Document standard CI tests #40

Open nottrobin opened 7 years ago

nottrobin commented 7 years ago

Thing we should test in all projects:

And then any unit tests, of course. But that's just nice to have

anthonydillon commented 7 years ago

I was wondering if this CI tests could/should be added to generator-canonical-webteam?

So, it asks if you would like to update the Travis file. If so, detects and updates missing CI dependences and drops a Travis file containing this list of common CI tasks to the project.

Then we can maintain a common CI across all of our projects a little more easily.

nottrobin commented 7 years ago

Absolutely it should. Travis already takes care of setting up flake8 and sass linting. But it doesn't mean it doesn't need to be documented here.

Although we hope the generator is used to set up new projects, there are cases where it won't work, or someone just doesn't know they're supposed to use it.

Our practices should be defined separately and in addition to the tools that help enforce them.

Lukewh commented 6 years ago

The list looks good and I'd also question percy. It regularly 'fails' and requires manual intervention when small styling changes are made that should be picked up by a design -/+ 1.

nottrobin commented 6 years ago

@Lukewh Added discussion about Percy to the dev catchup agenda.

nottrobin commented 6 years ago

In dev catch-up ^ we decided that Percy should indeed be included as a standard CI test.

Lukewh commented 6 years ago

^ As long as we disable dynamic content.