Add QA steps page - Githubissues

canonical-web-and-design / practices

Guides and principles from the web team at Canonical and Ubuntu

https://canonical-web-and-design.github.io/practices/

Other

44 stars 30 forks source link

Add QA steps page #65

Closed Caleb-Ellis closed 6 years ago

Caleb-Ellis commented 6 years ago

Done

Added a page on QA steps to go through, regardless of what the PR does (see dev catch-up about this). We could link this to a repo's PR template.

QA

Check that the QA steps are reasonable
Add anything you think is important

Issues

Fixes #66

steverydz commented 6 years ago

:+1:

Caleb-Ellis commented 6 years ago

@pmahnke Added

shivjoshi1996 commented 6 years ago

:+1:

nottrobin commented 6 years ago

@pmahnke technically, you're not supposed to "request changes":

The GitHub reviews features ("approve" and "request changes") should not be used, as all discussion is merely a discussion of opinions.

It may turn out to be a losing battle, but I just thought I'd mention it one more time.

nottrobin commented 6 years ago

Great work, thanks @Caleb-Ellis. Very happy to see these practices getting updated :smiley:

I made a few suggestions, but I don't feel strongly enough about any of them to block progress. You already have the required 2 :+1:s, so feel free to merge without any of my requests that you don't consider necessary.

anthonydillon commented 6 years ago

:+1: