search

canonical-web-and-design / practices

Guides and principles from the web team at Canonical and Ubuntu
https://canonical-web-and-design.github.io/practices/
Other
44 stars 30 forks source link

Add patterns for Discourse documentation #79

Closed nottrobin closed 6 years ago

nottrobin commented 6 years ago

@anthonydillon, @squidsoup I believe I've addressed all your points.

nottrobin commented 6 years ago

@squidsoup by the way, the way I originally wrote CONTRIBUTING.md, you're not technically supposed to officially "approve" PRs on this repo, but use :+1: instead:

To encourage participation and activity on the project, comments should remain as polite and accommodating as possible. The GitHub reviews features ("approve" and "request changes") should not be used, as all discussion is merely a discussion of opinions.

(In your case it was the "opinion" that "should" should be spelled correctly :wink:).

Although practically everyone has done it at some point, so maybe it was a foolhardy idea...

nottrobin commented 6 years ago

@anthonydillon, @squidsoup would either of you be happy enough with my fixes to give me a :+1: =)

anthonydillon commented 6 years ago

:+1: