canonical-web-and-design / practices

Guides and principles from the web team at Canonical and Ubuntu
https://canonical-web-and-design.github.io/practices/
Other
44 stars 30 forks source link

Removes code tag form navigation #99

Closed bartaz closed 5 years ago

bartaz commented 5 years ago

As much as I understand dev centric CONTRIBUTING.md it seems that <code> in main nav for some mysterious CSS reason doesn't work well making weird border show up under other elements.

screen shot 2018-11-20 at 15 43 23

This fixes that (by removing <code>).

nottrobin commented 5 years ago

:+1: from me

bartaz commented 5 years ago

Since this is more of a code change than a content change, I'm gonna just approve it like a code PR and merge it.

Thanks. I guess now that this repo contains both content and code we may need to update the contributing practices to reflect that ;)

nottrobin commented 5 years ago

@bartaz good point. Issue https://github.com/canonical-webteam/practices/issues/100 Woo!