canonical-web-and-design / vanilla-framework-react

An implementation of Vanilla Framework using React

19 stars 15 forks source link

98: Update storybook styling #116

Closed Caleb-Ellis closed 6 years ago

Caleb-Ellis commented 6 years ago

Done

Changed the withKnobs addon to be a global decorator, so it is only set once in .storybook/config.js and not in every story
Removed superfluous withKnobs decorators from stories
Added a custom global decorator that styles the component div with padding
Updated to vanilla 1.6.4

QA

Pull code
Run yarn lint and check there are no errors
Run yarn test and ensure that all tests still pass
Run ./run serve --watch and navigate to http://localhost:8102/
Check that padding has been added to the left and right of the component wrapper (i.e. they're not butted up against the component list or knobs panel)
Check that knobs still work

Fixes

Fixes #98

webteam-app commented 6 years ago

Starting demo at: http://vanilla-framework-react-pr-116.run.demo.haus/

kwm14 commented 6 years ago

@Caleb-Ellis looking good 👍