canonical-web-and-design / vanilla-framework-react

An implementation of Vanilla Framework using React
19 stars 15 forks source link

35: Updated Accordion and AccordionItem logic #45

Closed Caleb-Ellis closed 6 years ago

Caleb-Ellis commented 6 years ago

Done

QA

Fixes

Fixes #35, fixes #43

webteam-app commented 6 years ago

No ./run found. Unable to start demo.

barrymcgee commented 6 years ago

@Caleb-Ellis Two small points in code, otherwise, looks good.

barrymcgee commented 6 years ago

@Caleb-Ellis Also to note, for QA you no longer need to yarn build before yarn serve as the preserve script handles it.

Adding pre or post to any script name in a package.json will run it either before or after.

Caleb-Ellis commented 6 years ago

@barrymcgee good catches. I was never 100% certain why props had to be passed to the constructor. Good to know... you don't