Closed Caleb-Ellis closed 6 years ago
No ./run found. Unable to start demo.
@Caleb-Ellis Two small points in code, otherwise, looks good.
@Caleb-Ellis Also to note, for QA you no longer need to yarn build
before yarn serve
as the preserve
script handles it.
Adding pre
or post
to any script name in a package.json will run it either before or after.
@barrymcgee good catches. I was never 100% certain why props had to be passed to the constructor. Good to know... you don't
Done
QA
yarn clean
,yarn build
andyarn serve
yarn lint
andyarn test
and ensure there are no linting or testing errorsFixes
Fixes #35, fixes #43