search

canonical-web-and-design / vanilla-framework-react

An implementation of Vanilla Framework using React
19 stars 15 forks source link

Add run script to create demos #9

Closed barrymcgee closed 6 years ago

barrymcgee commented 7 years ago

@nottrobin Is it even possible to hook ./run into sites not set up using the Yeoman generator?

If not, can we disable the ./run demo bot on every PR?

nottrobin commented 7 years ago

A site/codebase doesn't use a Yeoman generator. You use a Yeoman generator (globally installed) to update a codebase.

The ./run script can be added manually or through the Yeoman generator, whatever works for you.

But obviously you only need demos if you have a web service to display a demo for. If that's not relevant to this project then you'll definitely want to disable demos somehow. I don't know how to do that - ask @WillMoggridge ?

barrymcgee commented 7 years ago

Bump @WillMoggridge ?

WillMoggridge commented 7 years ago

I got a quick ./run script working locally but I think #39 needs to be merged first, then I can propose a run script.

Caleb-Ellis commented 6 years ago

Issue resolved as of #54