WIP Multistage build - Githubissues

canonical-web-and-design / vanillaframework.io

Jekyll marketing site for Vanilla Framework

https://vanillaframework.io

4 stars 33 forks source link

WIP Multistage build #271

Closed carkod closed 4 years ago

carkod commented 4 years ago

Done

Implemented multistage build to reduce docker image sizes using reference from ubuntu.com

QA

Changes should not affect site
Check image size: docker build --tag myimage && docker images check myimage size
Revision ID is correctly added in the headers: docker build --tag myimage --build-arg BUILD_ID=myfakeid .
docker run -ti -p 8111:80 myimage
curl -I http://localhost:8111 to see if headers display "myfakeid"

Issue / Card

Multistage builds issue (#2142)
Standardize build-ids (#2096)

webteam-app commented 4 years ago

Starting demo at: https://vanillaframework-io-canonical-web-and-design-pr-271.run.demo.haus/

carkod commented 4 years ago

@nottrobin Have a look, because apparently the size went up with this multistage build...

I built a docker build --tag hello with the original Dockerfile (156 MB)
Then I built a docker build --tag bye with the new Dockerfile (233 MB)

bartaz commented 4 years ago

We moved vanillaframework.io to docs project. This is not needed anymore.