search

canonical-web-and-design / www.canonical.com

A databaseless django app powering http://www.canonical.com
Other
9 stars 24 forks source link

Remove dupe dependencies; upgrade cookie-policy and global-nav #334

Closed barrymcgee closed 5 years ago

barrymcgee commented 5 years ago

Done

I noticed renovate flagging duplicate dependencies between "dependencies" and "devDependencies" - so I deduped.

QA

  1. Check out this feature branch
  2. Run the site using the command ./run
  3. View the site locally in your web browser at: http://0.0.0.0:8002/
  4. Test command ./run build
  5. Test command ./run clean
    1. Test command ./run test
  7. Verify no errors.
webteam-app commented 5 years ago

Starting demo at: https://www-canonical-com-canonical-websites-pr-334.run.demo.haus/

pmahnke commented 5 years ago

@barrymcgee since the renovate PRs were done out of order, there are some conflicts, can you help fix?

barrymcgee commented 5 years ago

@pmahnke I've now fixed up all merge conflicts, split out the deps and devDeps and made sure all deps are pinned to their latest version.

I also then had to make changes to make sure updated cookie-policy and global-nav work.

Also updated 500.html nav as it was broken.

This all merits a full QA again please.